Skip to content

[INFRA] Put SDSL into contrib #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eseiler merged 1 commit into from
Feb 13, 2025
Merged

[INFRA] Put SDSL into contrib #3334

eseiler merged 1 commit into from
Feb 13, 2025

Conversation

@eseiler
Copy link
Member

@eseiler eseiler commented Feb 7, 2025

Creates an amalgamated version of sdsl in contrib and removes dependency on the sdsl repo.

  • sdsl-v3 is neither maintained nor widely packaged, the includes and namespaces clash with the more widely packages sdsl-v2
  • Because of that, we vendor/ship the sdsl anyway when building packages
  • After this change, we can switch to using find_package for cereal and have a somewhat mainstream CMake way of handling dependencies
  • Even though the header is 1 MB big, shipping the sdsl include directory takes 2 MB. A checkout of the sdsl is 5 MB. seqan3 checkout grows from 18 to 19 MB, the include from 5 to 6 MB.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 7, 2025
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 7, 2025
@seqan-actions
Copy link
Member

seqan-actions commented Feb 7, 2025

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3334

@codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (10fd0c7) to head (859c5b6).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3334   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         270      270           
  Lines       11913    11913           
  Branches      104      104           
=======================================
  Hits        11688    11688           
  Misses        225      225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SGSSGene
SGSSGene requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot!

test/scripts/amalgamate-sdsl.sh Outdated
@@ -0,0 +1,53 @@
#!/usr/bin/bash
Copy link
Contributor

@SGSSGene SGSSGene Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/usr/bin/bash
#!/usr/bin/env bash

Copy link
Contributor

@SGSSGene SGSSGene Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will force a lookup in the PATH variable for bash, for "interesting" system setups

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 12, 2025
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 12, 2025
@eseiler eseiler requested a review from SGSSGene February 12, 2025 13:02
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 12, 2025
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 12, 2025
SGSSGene
SGSSGene approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!

@eseiler eseiler enabled auto-merge February 13, 2025 11:02
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 13, 2025
@eseiler eseiler merged commit e6a6f1b into seqan:main Feb 13, 2025
40 checks passed
@eseiler eseiler deleted the infra/amalgamate branch February 13, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eseiler @seqan-actions @SGSSGene